kris/afv-library
1
0
Fork 0
mirror of https://github.com/forcedotcom/afv-library.git synced 2026-08-09 00:42:46 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
3bf5a3493c
afv-library/skills/data-cloud-bdt-expert/assets/sample_bdts/append_and_split.json

78 lines
3.2 KiB
JSON
Raw Normal View History

feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
{
"version": "66.0",
"nodes": {
"LOAD_WEB_ORDERS": {
"action": "load",
"sources": [],
"parameters": {
"dataset": {"name": "WebOrders__dlo", "type": "dataLakeObject"},
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"fields": ["OrderId__c", "Amount__c", "ChannelOrderKey__c"],
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
"sampleDetails": {"type": "TopN", "sortBy": []}
}
},
"LOAD_STORE_ORDERS": {
"action": "load",
"sources": [],
"parameters": {
"dataset": {"name": "StoreOrders__dlo", "type": "dataLakeObject"},
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"fields": ["OrderId__c", "Amount__c", "ChannelOrderKey__c"],
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
"sampleDetails": {"type": "TopN", "sortBy": []}
}
},
"APPEND_ALL_ORDERS": {
"action": "appendV2",
"sources": ["LOAD_WEB_ORDERS", "LOAD_STORE_ORDERS"],
"parameters": {
"allowImplicitDisjointSchema": false,
"fieldMappings": [
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
{"targetField": "OrderId__c", "sources": [{"node": "LOAD_WEB_ORDERS", "field": "OrderId__c"}, {"node": "LOAD_STORE_ORDERS", "field": "OrderId__c"}]},
{"targetField": "Amount__c", "sources": [{"node": "LOAD_WEB_ORDERS", "field": "Amount__c"}, {"node": "LOAD_STORE_ORDERS", "field": "Amount__c"}]},
{"targetField": "ChannelOrderKey__c", "sources": [{"node": "LOAD_WEB_ORDERS", "field": "ChannelOrderKey__c"}, {"node": "LOAD_STORE_ORDERS", "field": "ChannelOrderKey__c"}]}
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
]
}
},
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"SPLIT_CHANNEL_KEY": {
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
"action": "split",
"sources": ["APPEND_ALL_ORDERS"],
"parameters": {
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"sourceField": "ChannelOrderKey__c",
"delimiter": "-",
fix: address PRizm review findings from internal port PR @W-22196528@ Addresses 4 critical findings surfaced during PRizm code review of the internal plugin port of this skill (internal PR #19). Applying the same fixes here keeps the external canonical source and the internal port in sync. 1. Test cleanup discipline: switch `test_invalid_json_raises` from `try/finally` to `self.addCleanup(p.unlink, missing_ok=True)` — the unittest-idiomatic way to guarantee temp-file cleanup regardless of how the test exits. 2. `floor()` description in bdt-function-catalog.md: the old row was self-contradictory ("toward zero" AND "toward next integer up" in the same cell). Replace with a single coherent definition: rounds toward negative infinity; for negatives rounds away from zero (e.g., `floor(-2.3) = -3`). 3. Split-node documentation in bdt-node-catalog.md: the old doc claimed `split` routes rows into downstream branches via `branches[]` with per-branch predicates. That is not the canonical schema. Per `SplitParametersInputRepresentation` in core-262-public, `split` is a string-splitting operation: one `sourceField` + `delimiter` → N `targetFields` (one row in, one row out; columns added). Rewrote the section with the correct parameters, lineage effect, gotchas, and a canonical example. Row-routing belongs in `filter` nodes. 4. Sample `assets/sample_bdts/append_and_split.json`: the old sample used the invented `branches[]` shape AND routed the same split into two downstream outputs that each expected different rows — which is not how `split` works. Rewrote the sample so: - `appendV2` unions two order sources (unchanged intent). - `split` uses canonical `{sourceField, delimiter, targetFields}` splitting `CustomerFullName__c` into first + last name columns. - One downstream output consumes the new columns (removes the fake two-branch fan-out). Tests: 92/92 passing. Sample parses and runs through `bdt_analyze.py summary` cleanly (5 nodes: 2 load + 1 appendV2 + 1 split + 1 outputD360). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 12:49:36 +08:00
"targetFields": [
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
{"name": "Channel__c", "label": "Channel"},
{"name": "OrderNumber__c", "label": "Order Number"}
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
]
}
},
fix: address PRizm review findings from internal port PR @W-22196528@ Addresses 4 critical findings surfaced during PRizm code review of the internal plugin port of this skill (internal PR #19). Applying the same fixes here keeps the external canonical source and the internal port in sync. 1. Test cleanup discipline: switch `test_invalid_json_raises` from `try/finally` to `self.addCleanup(p.unlink, missing_ok=True)` — the unittest-idiomatic way to guarantee temp-file cleanup regardless of how the test exits. 2. `floor()` description in bdt-function-catalog.md: the old row was self-contradictory ("toward zero" AND "toward next integer up" in the same cell). Replace with a single coherent definition: rounds toward negative infinity; for negatives rounds away from zero (e.g., `floor(-2.3) = -3`). 3. Split-node documentation in bdt-node-catalog.md: the old doc claimed `split` routes rows into downstream branches via `branches[]` with per-branch predicates. That is not the canonical schema. Per `SplitParametersInputRepresentation` in core-262-public, `split` is a string-splitting operation: one `sourceField` + `delimiter` → N `targetFields` (one row in, one row out; columns added). Rewrote the section with the correct parameters, lineage effect, gotchas, and a canonical example. Row-routing belongs in `filter` nodes. 4. Sample `assets/sample_bdts/append_and_split.json`: the old sample used the invented `branches[]` shape AND routed the same split into two downstream outputs that each expected different rows — which is not how `split` works. Rewrote the sample so: - `appendV2` unions two order sources (unchanged intent). - `split` uses canonical `{sourceField, delimiter, targetFields}` splitting `CustomerFullName__c` into first + last name columns. - One downstream output consumes the new columns (removes the fake two-branch fan-out). Tests: 92/92 passing. Sample parses and runs through `bdt_analyze.py summary` cleanly (5 nodes: 2 load + 1 appendV2 + 1 split + 1 outputD360). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-24 12:49:36 +08:00
"OUTPUT_ORDERS": {
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
"action": "outputD360",
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"sources": ["SPLIT_CHANNEL_KEY"],
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
"parameters": {
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"name": "OrdersWithChannel__dlm",
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
"type": "dataModelObject",
"writeMode": "OVERWRITE",
"fieldsMappings": [
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
{"sourceField": "OrderId__c", "targetField": "OrderId__c"},
{"sourceField": "Amount__c", "targetField": "Amount__c"},
{"sourceField": "Channel__c", "targetField": "Channel__c"},
{"sourceField": "OrderNumber__c", "targetField": "OrderNumber__c"}
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
]
}
}
},
"ui": {
"nodes": {
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
"LOAD_WEB_ORDERS": {"label": "Web Orders", "type": "LOAD_DATASET", "top": 100, "left": 100},
"LOAD_STORE_ORDERS": {"label": "Store Orders", "type": "LOAD_DATASET", "top": 260, "left": 100},
"APPEND_ALL_ORDERS": {"label": "Union", "type": "APPEND", "top": 180, "left": 260},
"SPLIT_CHANNEL_KEY": {"label": "Split channel key", "type": "SPLIT", "top": 180, "left": 420},
"OUTPUT_ORDERS": {"label": "Orders + channel", "type": "OUTPUT", "top": 180, "left": 580}
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
},
"connectors": [
fix: address PRizm round-2 review findings from internal port @W-22196528@ Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
2026-04-24 13:25:18 +08:00
{"source": "LOAD_WEB_ORDERS", "target": "APPEND_ALL_ORDERS"},
{"source": "LOAD_STORE_ORDERS", "target": "APPEND_ALL_ORDERS"},
{"source": "APPEND_ALL_ORDERS", "target": "SPLIT_CHANNEL_KEY"},
{"source": "SPLIT_CHANNEL_KEY", "target": "OUTPUT_ORDERS"}
feat(bdt): reference docs + sample BDTs @W-22196528@ Adds the curated reference library the skill loads on demand, plus four synthetic sample BDTs used by docs, tests, and LLM-mode demos. references/ (4 curated Markdown files): - bdt-reference.md — top-level BDT JSON anatomy: envelope, nodes, edges, UI layer, definitions, businessType semantics. Cites the core-262 upstream JSON schema and Connect API spec. - bdt-node-catalog.md — every node type (DMO Source, DMO Sink, Filter, Join, Union, Aggregate, Window, Formula, Split, Append, etc.) with its required/optional fields and typical usage. Audited against core-262 enums. - bdt-function-catalog.md — the expression-language function surface (string, numeric, date, conditional, aggregate). Grouped by category with signature + one-line semantics. - bdt-window-functions.md — windowing operators (ROW_NUMBER, RANK, LEAD/LAG, running aggregates) with PARTITION BY / ORDER BY grammar and gotchas. assets/sample_bdts/ (4 synthetic, dependency-free BDTs): - minimal_dmo_to_dmo.json — smallest valid BDT (1 source, 1 sink). - joins_and_filters.json — join + filter composition. - window_and_aggregate.json — window function + aggregate in one graph. - append_and_split.json — append-then-split branching topology. Grounding rules enforced in this commit: - Every claim in references/ cites an upstream source (core-262 JSON schema, Connect API reference, or the Data Cloud BDT editor spec). No speculative content. - No raw DITA or internal-only documentation is shipped; references are synthesized from public-facing material. - BusinessTypeEnum values use the canonical camelCase casing from core-262 (case-cleanup fix included here). - Sample BDTs are original synthetic fixtures, not redacted customer data. Each is small enough to read end-to-end. @W-22196528@
2026-04-24 01:15:27 +08:00
]
}
}
Reference in New Issue Copy Permalink