kris/afv-library
1
0
Fork 0
mirror of https://github.com/forcedotcom/afv-library.git synced 2026-07-30 03:09:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

fix: allow nested YAML lists in metadata sub-keys (sync with internal) @W-23173617@ (#298)

Browse Source 
fix: allow nested YAML lists in metadata sub-keys (sync with internal)

The validator incorrectly rejected skills with list-type fields (e.g.
cliTools) nested under metadata sub-keys. This syncs the
parseMetadataBlock() fix from sf-skills-internal that distinguishes
direct-child lists from nested ones.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Jasmine Kaur 2026-06-25 20:33:56 +05:30 committed by GitHub
parent 19ee934c67
commit a95d0d3f82
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
scripts/validate-skills.ts
View File

@ -420,7 +420,8 @@ Wrap values that contain \`: \` (colon + space), such as long descriptions with
/** /**
* Extracts nested key-value pairs from the `metadata:` block in raw frontmatter. * Extracts nested key-value pairs from the `metadata:` block in raw frontmatter.
* Returns `null` if no metadata block, `"scalar"` if metadata has an inline value, * Returns `null` if no metadata block, `"scalar"` if metadata has an inline value,
* `"list"` if it contains YAML list items, or a `Record` of sub-keys. * `"list"` if direct children are YAML list items, or a `Record` of sub-keys.
* Nested lists under sub-keys (e.g. cliTools: [{tool:"sf"}]) are allowed.
*/ */
function parseMetadataBlock(rawFrontmatter: string): Record<string, string> | "scalar" | "list" | null { function parseMetadataBlock(rawFrontmatter: string): Record<string, string> | "scalar" | "list" | null {
const lines = rawFrontmatter.split(/\r?\n/) const lines = rawFrontmatter.split(/\r?\n/)
@ -431,12 +432,16 @@ function parseMetadataBlock(rawFrontmatter: string): Record<string, string> | "s
const inlineValue = metaLine.slice(metaLine.indexOf(":") + 1).trim() const inlineValue = metaLine.slice(metaLine.indexOf(":") + 1).trim()
if (inlineValue && !inlineValue.startsWith("#")) return "scalar" if (inlineValue && !inlineValue.startsWith("#")) return "scalar"
let directIndent: number | null = null
const result: Record<string, string> = {} const result: Record<string, string> = {}
for (let i = metaIdx + 1; i < lines.length; i++) { for (let i = metaIdx + 1; i < lines.length; i++) {
const line = lines[i] const line = lines[i]
if (!line.startsWith(" ") && !line.startsWith("\t")) break if (!line.startsWith(" ") && !line.startsWith("\t")) break
const indent = line.length - line.trimStart().length
if (directIndent === null) directIndent = indent
const trimmed = line.trim() const trimmed = line.trim()
if (trimmed.startsWith("- ")) return "list" if (indent === directIndent && trimmed.startsWith("- ")) return "list"
if (indent !== directIndent) continue
const colonIdx = trimmed.indexOf(":") const colonIdx = trimmed.indexOf(":")
if (colonIdx === -1) continue if (colonIdx === -1) continue
const key = trimmed.slice(0, colonIdx).trim() const key = trimmed.slice(0, colonIdx).trim()