mirror of
https://github.com/forcedotcom/afv-library.git
synced 2026-08-09 00:42:46 +08:00
67d919947f
Ports the 14 applicable round-2 fixes from the internal PRizm review to the external afv-library source. (plugin.json finding #13 is internal-only and does not apply here.) Accepted fixes: 1 bdt_analyze.py select_definition: isinstance(index, int) -> type(index) is int (reject bool subclass of int). 2 bdt_analyze.py cmd_formula: precompute upstream fields_produced map to eliminate O(consumed x upstream) recomputation. 3 bdt_analyze.py topo_order: replace sort-on-every-iteration with deque-based Kahn (preserves deterministic order). 4 test_bdt_analyze.py test_all_subcommands_work_on_api_input: wrap loop in self.subTest for per-iteration failure reporting. 5 test_bdt_analyze.py test_invalid_json_raises: register addCleanup BEFORE write_text so cleanup runs even if write fails. 6 SKILL.md: remove misleading "strip __c suffix" field-trace troubleshooting advice; replace with source-DMO passthrough guidance. 7 SKILL.md: rewrite cycle error message to direct user to Data Cloud viewer (re-export will not fix a cycle in the BDT definition). 8 SKILL.md: add explicit --definition N flag documentation and list every subcommand that accepts it. 9 SKILL.md: refine I2 routing guidance — pick the earliest formula/ computeRelative node, not the output mapping. 11 bdt-function-catalog.md: clean floor() wording ("always rounds down on the number line"). 12 bdt-node-catalog.md: businessType enum — assert list is canonical/complete; instruct skill to surface+flag any unknown value. 14 append_and_split.json: change split subject from fragile CustomerFullName__c split-on-space to ChannelOrderKey__c split-on-hyphen; avoids name-parsing pitfall (middle names / multi-space). 15 window_and_aggregate.json: use the computed OrderRank__c via a new FIRST_ORDER_AMOUNT formula node (case when rank=1 then amount else 0) feeding AGG_BY_ACCOUNT; illustrates the rank+formula+aggregate idiom. 16 joins_and_filters.json: add explicit IS_NOT_NULL filter expression on GrandTotalAmount__c (defense-in-depth beyond GREATER_THAN 0). Rejected finding (rationale posted as PR comment): 10 bdt-node-catalog.md split section — reviewer claimed split is a pipeline-branching node. Canonical sources (core-262 SplitParametersInputRepresentation.java + Salesforce help DITA c360_a_batch_transform_split.xml) both describe split as a string-splitting operation. Current docs are correct; not changing. Tests: 92/92 passing.
78 lines
3.2 KiB
JSON
78 lines
3.2 KiB
JSON
{
|
|
"version": "66.0",
|
|
"nodes": {
|
|
"LOAD_WEB_ORDERS": {
|
|
"action": "load",
|
|
"sources": [],
|
|
"parameters": {
|
|
"dataset": {"name": "WebOrders__dlo", "type": "dataLakeObject"},
|
|
"fields": ["OrderId__c", "Amount__c", "ChannelOrderKey__c"],
|
|
"sampleDetails": {"type": "TopN", "sortBy": []}
|
|
}
|
|
},
|
|
"LOAD_STORE_ORDERS": {
|
|
"action": "load",
|
|
"sources": [],
|
|
"parameters": {
|
|
"dataset": {"name": "StoreOrders__dlo", "type": "dataLakeObject"},
|
|
"fields": ["OrderId__c", "Amount__c", "ChannelOrderKey__c"],
|
|
"sampleDetails": {"type": "TopN", "sortBy": []}
|
|
}
|
|
},
|
|
"APPEND_ALL_ORDERS": {
|
|
"action": "appendV2",
|
|
"sources": ["LOAD_WEB_ORDERS", "LOAD_STORE_ORDERS"],
|
|
"parameters": {
|
|
"allowImplicitDisjointSchema": false,
|
|
"fieldMappings": [
|
|
{"targetField": "OrderId__c", "sources": [{"node": "LOAD_WEB_ORDERS", "field": "OrderId__c"}, {"node": "LOAD_STORE_ORDERS", "field": "OrderId__c"}]},
|
|
{"targetField": "Amount__c", "sources": [{"node": "LOAD_WEB_ORDERS", "field": "Amount__c"}, {"node": "LOAD_STORE_ORDERS", "field": "Amount__c"}]},
|
|
{"targetField": "ChannelOrderKey__c", "sources": [{"node": "LOAD_WEB_ORDERS", "field": "ChannelOrderKey__c"}, {"node": "LOAD_STORE_ORDERS", "field": "ChannelOrderKey__c"}]}
|
|
]
|
|
}
|
|
},
|
|
"SPLIT_CHANNEL_KEY": {
|
|
"action": "split",
|
|
"sources": ["APPEND_ALL_ORDERS"],
|
|
"parameters": {
|
|
"sourceField": "ChannelOrderKey__c",
|
|
"delimiter": "-",
|
|
"targetFields": [
|
|
{"name": "Channel__c", "label": "Channel"},
|
|
{"name": "OrderNumber__c", "label": "Order Number"}
|
|
]
|
|
}
|
|
},
|
|
"OUTPUT_ORDERS": {
|
|
"action": "outputD360",
|
|
"sources": ["SPLIT_CHANNEL_KEY"],
|
|
"parameters": {
|
|
"name": "OrdersWithChannel__dlm",
|
|
"type": "dataModelObject",
|
|
"writeMode": "OVERWRITE",
|
|
"fieldsMappings": [
|
|
{"sourceField": "OrderId__c", "targetField": "OrderId__c"},
|
|
{"sourceField": "Amount__c", "targetField": "Amount__c"},
|
|
{"sourceField": "Channel__c", "targetField": "Channel__c"},
|
|
{"sourceField": "OrderNumber__c", "targetField": "OrderNumber__c"}
|
|
]
|
|
}
|
|
}
|
|
},
|
|
"ui": {
|
|
"nodes": {
|
|
"LOAD_WEB_ORDERS": {"label": "Web Orders", "type": "LOAD_DATASET", "top": 100, "left": 100},
|
|
"LOAD_STORE_ORDERS": {"label": "Store Orders", "type": "LOAD_DATASET", "top": 260, "left": 100},
|
|
"APPEND_ALL_ORDERS": {"label": "Union", "type": "APPEND", "top": 180, "left": 260},
|
|
"SPLIT_CHANNEL_KEY": {"label": "Split channel key", "type": "SPLIT", "top": 180, "left": 420},
|
|
"OUTPUT_ORDERS": {"label": "Orders + channel", "type": "OUTPUT", "top": 180, "left": 580}
|
|
},
|
|
"connectors": [
|
|
{"source": "LOAD_WEB_ORDERS", "target": "APPEND_ALL_ORDERS"},
|
|
{"source": "LOAD_STORE_ORDERS", "target": "APPEND_ALL_ORDERS"},
|
|
{"source": "APPEND_ALL_ORDERS", "target": "SPLIT_CHANNEL_KEY"},
|
|
{"source": "SPLIT_CHANNEL_KEY", "target": "OUTPUT_ORDERS"}
|
|
]
|
|
}
|
|
}
|